potiuk commented on code in PR #32709:
URL: https://github.com/apache/airflow/pull/32709#discussion_r1288360213
##########
airflow/api/client/api_client.py:
##########
@@ -60,12 +60,13 @@ def get_pools(self):
"""Get all pools."""
raise NotImplementedError()
- def create_pool(self, name, slots, description):
+ def create_pool(self, name, slots, description, include_deferred):
Review Comment:
Yeah. just realied taht. My bad. Actually - this was fine how it was before.
I realized that the CLI command is still using tha API (Historical reason) but
it is NOT the experimental API- it was internal API used in the past by the
clients and we moved away from it in newer CLIs. There is absolutely no
guarantees about this API that we give - so your change was good as it was.
resetting my change.
##########
airflow/api/client/api_client.py:
##########
@@ -60,12 +60,13 @@ def get_pools(self):
"""Get all pools."""
raise NotImplementedError()
- def create_pool(self, name, slots, description):
+ def create_pool(self, name, slots, description, include_deferred):
Review Comment:
Yeah. just realied taht. My bad. Actually - this was fine how it was before.
I realized that the CLI command is still using tha API (Historical reason) but
it is NOT the experimental API- it was internal API used in the past by the
clients and we moved away from it in newer CLIs. There are absolutely no
guarantees about this API that we give - so your change was good as it was.
resetting my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
