uranusjr commented on code in PR #33266: URL: https://github.com/apache/airflow/pull/33266#discussion_r1289610118
########## airflow/serialization/serde.py: ########## @@ -286,7 +286,7 @@ def _convert(old: dict) -> dict: def _match(classname: str) -> bool: - return any(p.match(classname) is not None for p in _get_patterns()) + return any(p.match(classname) for p in _get_patterns()) Review Comment: I prefer the `is not None` variant for explicitness. There’s not perceivable performance difference also. ########## airflow/serialization/serde.py: ########## @@ -286,7 +286,7 @@ def _convert(old: dict) -> dict: def _match(classname: str) -> bool: - return any(p.match(classname) is not None for p in _get_patterns()) + return any(p.match(classname) for p in _get_patterns()) Review Comment: I prefer the `is not None` variant for explicitness. There’s not perceivable performance difference also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
