uranusjr commented on code in PR #33227:
URL: https://github.com/apache/airflow/pull/33227#discussion_r1289638627
##########
airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -282,13 +282,11 @@ def run_cli(
)
self.sub_process = sub_process
stdout = ""
- while True:
- line = sub_process.stdout.readline()
- if not line:
- break
- stdout += line.decode("UTF-8")
+ for line in iter(sub_process.stdout.readline, b""):
+ line = line.decode("UTF-8")
Review Comment:
```suggestion
line = line.decode()
```
UTF8 is the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
