hussein-awala commented on code in PR #32318:
URL: https://github.com/apache/airflow/pull/32318#discussion_r1290745557
##########
airflow/models/trigger.py:
##########
@@ -244,8 +245,9 @@ def assign_unassigned(
def get_sorted_triggers(cls, capacity, alive_triggerer_ids, session):
query = with_row_locks(
select(cls.id)
+ .join(TaskInstance, cls.id == TaskInstance.trigger_id,
isouter=False)
Review Comment:
Since there is no Triggers to process without being associated to a TI (if
there is no TI with the trigger id, it means that the trigger is already
executed and has returned an event) , it should be fine to use inner join here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]