potiuk commented on code in PR #33224: URL: https://github.com/apache/airflow/pull/33224#discussion_r1292198082
########## docs/apache-airflow-providers-cncf-kubernetes/operators.rst: ########## @@ -152,6 +152,10 @@ XCom values differently than other operators. In order to pass a XCom value from your Pod you must specify the ``do_xcom_push`` as ``True``. This will create a sidecar container that runs alongside the Pod. The Pod must write the XCom value into this location at the ``/airflow/xcom/return.json`` path. +.. note:: + An invalid json content will fail, example ``echo 'hello' > /airflow/xcom/return.json`` fail and ``echo '\"hello\"' > /airflow/xcom/return.json`` work Review Comment: See the specs: https://www.json.org/json-en.html -> any value on it's own (string) is perfectly valid json. Also array is. What you **think** about json is the "object" part of it where you can define complex objects by combining different value types in more complex structures. But each "value" separately is also a valid json. Strings in JSON must be `"` quoted, so `hello` is not a valid value in json, but `"hello"` is. Also for example `23` is valid json (numeric value). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
