potiuk opened a new pull request, #33364:
URL: https://github.com/apache/airflow/pull/33364
Even the latest pip can enter into a long loop of backtracking when trying
to find latest "good" set of dependencies with eager upgrade. This happened on
August 10th 2023 with aiobotocore causing backtracking.
This PR adds a complete set of tools and instructions that can help in such
cases and figure out which newly released dependency causes backtracking.
The toolset consists of:
* adding timeout on the image build, so that it can fail before the job
timeout and provide useful instructions what to do
* adding `ci find-backtracking-candidates` that allows to identify the
packages released after the last successful constraint update that could be the
reason for backtracking
* running the `find-backtracking-candidates` command in the CI when timeout
occurs - this will help to see the candidates as early as possible - at the
first build that will fail with timeout. This should help with narrowing down
the root cause much faster
* adding detailed explanation why we have the problem and how to deal with
it step-by-step, including example based on the August 2023 backtracking issue
with aiobotocore
* finally removing `--empty-image` switch and pushing empty images in CI.
This was an attempt to speed up waiting for image in case the image failed, but
what it did, it has hidden the failures of the images when they failed. It does
not really add value any more, since "image waiting" is now always done using
small public runners, waiting till timeout for those is not a big issue.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
