uranusjr commented on code in PR #33309:
URL: https://github.com/apache/airflow/pull/33309#discussion_r1293681019
##########
airflow/cli/commands/task_command.py:
##########
@@ -634,6 +635,12 @@ def task_test(args, dag: DAG | None = None) -> None:
session.delete(ti.dag_run)
+@provide_session
+def render_template_with_session(ti: TaskInstance, session=NEW_SESSION):
+ with set_current_task_instance_session(session=session):
+ ti.render_templates()
Review Comment:
There’s `create_session`, a decorator is not needed.
```python
with create_session() as session,
set_current_task_instance_session(session=session):
ti.render_templates()
```
##########
airflow/cli/commands/task_command.py:
##########
@@ -634,6 +635,12 @@ def task_test(args, dag: DAG | None = None) -> None:
session.delete(ti.dag_run)
+@provide_session
+def render_template_with_session(ti: TaskInstance, session=NEW_SESSION):
+ with set_current_task_instance_session(session=session):
+ ti.render_templates()
Review Comment:
There’s `create_session`, a decorator is not needed.
```python
with create_session() as session,
set_current_task_instance_session(session=session):
ti.render_templates()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
