Owen-CH-Leung commented on code in PR #33306:
URL: https://github.com/apache/airflow/pull/33306#discussion_r1294127625
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -508,17 +522,21 @@ def await_container_completion(self, pod: V1Pod,
container_name: str) -> None:
self.log.info("Waiting for container '%s' state to be completed",
container_name)
time.sleep(1)
- def await_pod_completion(self, pod: V1Pod) -> V1Pod:
+ def await_pod_completion(self, istio_enabled: bool, pod: V1Pod,
container_name: str) -> V1Pod:
Review Comment:
Thanks. Sure I've make `pod` arg as first value and make the other two
optional with default value if not specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
