uranusjr commented on code in PR #33413:
URL: https://github.com/apache/airflow/pull/33413#discussion_r1295358300
##########
airflow/www/forms.py:
##########
@@ -124,21 +124,28 @@ class DagRunEditForm(DynamicForm):
We don't actually want to allow editing, so everything is read-only here.
"""
- dag_id = StringField(lazy_gettext("Dag Id"), widget=BS3TextFieldROWidget())
- start_date = DateTimeWithTimezoneField(lazy_gettext("Start Date"),
widget=AirflowDateTimePickerROWidget())
- end_date = DateTimeWithTimezoneField(lazy_gettext("End Date"),
widget=AirflowDateTimePickerROWidget())
- run_id = StringField(lazy_gettext("Run Id"), widget=BS3TextFieldROWidget())
- state = StringField(lazy_gettext("State"), widget=BS3TextFieldROWidget())
+ dag_id = StringField(lazy_gettext("Dag Id"), validators=[ReadOnly()],
widget=BS3TextFieldROWidget())
+ start_date = DateTimeWithTimezoneField(
+ lazy_gettext("Start Date"), validators=[ReadOnly()],
widget=AirflowDateTimePickerROWidget()
+ )
+ end_date = DateTimeWithTimezoneField(
+ lazy_gettext("End Date"), validators=[ReadOnly()],
widget=AirflowDateTimePickerROWidget()
+ )
+ run_id = StringField(lazy_gettext("Run Id"), validators=[ReadOnly()],
widget=BS3TextFieldROWidget())
+ state = StringField(lazy_gettext("State"), validators=[ReadOnly()],
widget=BS3TextFieldROWidget())
execution_date = DateTimeWithTimezoneField(
lazy_gettext("Logical Date"),
+ validators=[ReadOnly()],
widget=AirflowDateTimePickerROWidget(),
)
- conf = TextAreaField(lazy_gettext("Conf"), widget=BS3TextAreaROWidget())
+ conf = TextAreaField(lazy_gettext("Conf"), validators=[ReadOnly()],
widget=BS3TextAreaROWidget())
note = TextAreaField(lazy_gettext("User Note"),
widget=BS3TextAreaFieldWidget())
Review Comment:
This is editable right? So the class docstring should be modified a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
