eladkal commented on code in PR #32606: URL: https://github.com/apache/airflow/pull/32606#discussion_r1295832572
########## airflow/providers/google/cloud/hooks/cloud_batch.py: ########## @@ -0,0 +1,215 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import itertools +import json +from time import sleep +from typing import Iterable, Sequence + +from google.api_core import operation # type: ignore +from google.cloud.batch import ListJobsRequest, ListTasksRequest +from google.cloud.batch_v1 import ( + BatchServiceAsyncClient, + BatchServiceClient, + CreateJobRequest, + Job, + JobStatus, + Task, +) +from google.cloud.batch_v1.services.batch_service import pagers + +from airflow.exceptions import AirflowException +from airflow.providers.google.common.consts import CLIENT_INFO +from airflow.providers.google.common.hooks.base_google import PROVIDE_PROJECT_ID, GoogleBaseHook + + +class CloudBatchHook(GoogleBaseHook): + """ + Hook for the Google Cloud Batch service. + + :param gcp_conn_id: The connection ID to use when fetching connection info. + :param impersonation_chain: Optional service account to impersonate using short-term + credentials, or chained list of accounts required to get the access_token + of the last account in the list, which will be impersonated in the request. + If set as a string, the account must grant the originating account + the Service Account Token Creator IAM role. + If set as a sequence, the identities from the list must grant + Service Account Token Creator IAM role to the directly preceding identity, with first + account from the list granting this role to the originating account. + """ + + def __init__( + self, + gcp_conn_id: str = "google_cloud_default", + impersonation_chain: str | Sequence[str] | None = None, + **kwargs, + ) -> None: + if kwargs.get("delegate_to") is not None: + raise RuntimeError( + "The `delegate_to` parameter has been deprecated before and finally removed in this version" + " of Google Provider. You MUST convert it to `impersonate_chain`" + ) + super().__init__(gcp_conn_id=gcp_conn_id, impersonation_chain=impersonation_chain) Review Comment: Lets not add this to new operators. same reasoning as https://github.com/apache/airflow/pull/33067#discussion_r1295712293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
