o-nikolas commented on code in PR #33423: URL: https://github.com/apache/airflow/pull/33423#discussion_r1296180175
########## airflow/cli/cli_parser.py: ########## Review Comment: > there is log.fatal which is marked deprecated in favor of log.critical, the highest level of logging. I was thinking he was refering to that. > https://docs.python.org/3/library/logging.html#logging-levels There is no mention of fatal in that doc link. I did however find [this](https://stackoverflow.com/a/31170378), it explains that both critical and fatal were there from the start but the latter only as sort of a "compat" with log4j (since the Java folks use FATAL as the highest level). From the original logging PEP: > The term CRITICAL is used in preference to FATAL, which is used by log4j. The levels are conceptually the same - that of a serious, or very serious, error. However, FATAL implies death, which in Python implies a raised and uncaught exception, traceback, and exit. Since the logging module does not enforce such an outcome from a FATAL-level log entry, it makes sense to use CRITICAL in preference to FATAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
