hussein-awala commented on code in PR #33424:
URL: https://github.com/apache/airflow/pull/33424#discussion_r1297706555
##########
airflow/sensors/base.py:
##########
@@ -281,6 +282,16 @@ def run_duration() -> float:
self.log.info("Success criteria met. Exiting.")
return xcom_value
+ def resume_execution(self, next_method: str, next_kwargs: dict[str, Any] |
None, context: Context):
+ try:
+ return super().resume_execution(next_method, next_kwargs, context)
+ except (AirflowException, TaskDeferralError) as e:
+ if self.soft_fail:
+ raise AirflowSkipException(e)
+ raise
+ except Exception:
Review Comment:
IMHO, I don't think so, soft fail should be used when the sensor returns a
False value or it's timeout, so we cannot skip the task if there is a failure.
I'm preparing a PR for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
