mikaeld commented on code in PR #32724: URL: https://github.com/apache/airflow/pull/32724#discussion_r1298570195
########## chart/templates/secrets/pgbouncer-stats-secret.yaml: ########## Review Comment: I just realized my code did not reflect my original intent and you are right that things 💣 I've update the template and added a unit test. If secret key is defined but secret name is undefined, it will use the chart-included secret. If secret key is undefined but secret name is defined, it will use the external secret name with the `connection` key. ########## chart/templates/secrets/pgbouncer-stats-secret.yaml: ########## Review Comment: I just realized my code did not reflect my original intent and you are right that things 💣 I've update the template and added a unit test. If secret key is defined but secret name is undefined, it will use the chart-included secret. If secret key is undefined but secret name is defined, it will use the external secret name with the `connection` key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
