vandonr-amz commented on code in PR #33481: URL: https://github.com/apache/airflow/pull/33481#discussion_r1300508435
########## airflow/auth/managers/fab/cli_commands/utils.py: ########## Review Comment: hmm, you mean we should leave them as abstract methods (i.e. keep the declaration in place) and only move the implementation to the FAB folder ? I'm not sure I agree with you, I think those methods are not needed outside of the commands I moved (or plan to move), so I don't see why we'd keep them in core 🤔 ########## airflow/auth/managers/fab/cli_commands/utils.py: ########## Review Comment: hmm, you mean we should leave them as abstract methods (i.e. keep the declaration in place) and only move the implementation to the FAB folder ? I'm not sure I agree with you, I think those methods are not needed outside of the commands I moved (or plan to move), so I don't see why we'd keep them in core 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
