Taragolis commented on issue #33596: URL: https://github.com/apache/airflow/issues/33596#issuecomment-1687024435
> I could list both classes in connection-types of provider.yaml, but keep both as connection-type: pinot, but there will be two connection types with the same name (which may not be possible?): AFAIK it just took the last one. > I know we will need to change create_default_connections in airflow/utils/db.py (as shown above) if we end up changing the connection types. Possibly other places, but I have not seen any other references of conn_type="pinot" beside the default connections. I'm not sure that we need to change this values, most of them just for demonstrations. And it quite difficult to keep it updated, because "default" connections sits inside of core, and providers might work on different versions of Airflow, for example now min supported version for providers is 2.4 In additional most of the (if not all) Hooks ignore "connection_type", so if you want to contribute changes to Apache Pinot provider you also could choose name for connection. BTW, if you want to work on this issue you also might help in other task and add missing documentation for Apache Pinot, see: https://github.com/apache/airflow/issues/28790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
