potiuk commented on PR #33574: URL: https://github.com/apache/airflow/pull/33574#issuecomment-1687611731
> @potiuk build-docs is fixed, please take a look at the second issue Interesting one. It actually revealed an interesting bug/edge case/optimization possibility. And it motivated me to implement https://github.com/apache/airflow/pull/33603 - optimization that I wanted to do for some time. What happened in this case - the job that failed was run as part of provider check and in this check we do two things: 1) we simulate preparation of provider decumentation - as if release manager run the documentation generation (helps us to check if the tooling still works) 2) then we build provider packages The point 1) modified provider.yaml files for all the providers that were updated since last release (including yandex) Then, when 2) was attempted, breeze detected that provider.yaml files changed and attempted to rebuild the CI image - normally it is a "no-op" because we just built the image with the constraints. But yandex provider has no constraints generated, so `pip` attempted to build the image without constraints, and apparently some of the constraints of yandes are not compatible with the current set of constraints so building the image faild. The optimization in #33603 will solve it in a bit indirect way - when provider.yaml are updated by documentation preparation, breeze will first attempt to regenerate "generated/provider_dependencies.json" and only this file change it will attempt to rebuild the image. Result - slightly faster and more accurate "check providers" job in CI, less frequent prompts for rebuilding the image for regular developers in breeze, the "generated/provider_dependencies.json" will be generated as needed when you just run breeze, without the need to have pre-commit installed. Once #33603 gets merged. you should rebase and I believe the job will succeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
