potiuk commented on PR #33578: URL: https://github.com/apache/airflow/pull/33578#issuecomment-1688734017
We are about to unsuspend yandex provider (which was the main reason why the PR failed) . You should rebase after we merge it: #33574 To be honest, I am not sure if we need it. I think there is a very little benefit from having such "common" provider. We already have (and continue having) a big share of problems resulting from common.sql extraction - and there was a good reason for that extraction - i.e. Open Lineage integration might benefit from it. With Filesstem, I am not sure what are the benefits. The key thing is -extracing code is cool (because of DRY) but it introduces coupling (i.e. all users of the common code become implicitly dependent). And it introduces all kinds of issues where change in the common code might lead to dubtle bugs in related providers. I yet fail to see what would be the benefits of introducing such common code. But maybe I am short-sited? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
