uranusjr commented on code in PR #33626:
URL: https://github.com/apache/airflow/pull/33626#discussion_r1302421102
##########
airflow/providers/google/cloud/operators/spanner.py:
##########
@@ -302,7 +302,7 @@ def sanitize_queries(queries: list[str]) -> None:
:param queries: queries
"""
if queries and queries[-1] == "":
- del queries[-1]
+ queries.pop()
Review Comment:
I’m not sure I like using `pop()` more
##########
airflow/providers/google/cloud/operators/spanner.py:
##########
@@ -302,7 +302,7 @@ def sanitize_queries(queries: list[str]) -> None:
:param queries: queries
"""
if queries and queries[-1] == "":
- del queries[-1]
+ queries.pop()
Review Comment:
I’m not sure I like using `pop()` more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
