uranusjr commented on code in PR #33403:
URL: https://github.com/apache/airflow/pull/33403#discussion_r1303946632
##########
airflow/sensors/date_time.py:
##########
@@ -85,9 +85,13 @@ class DateTimeSensorAsync(DateTimeSensor):
:param target_time: datetime after which the job succeeds. (templated)
"""
+ def __init__(self, **kwargs) -> None:
+ super().__init__(**kwargs)
+ self.trigger = DateTimeTrigger(moment=timezone.parse(self.target_time))
+
def execute(self, context: Context):
self.defer(
- trigger=DateTimeTrigger(moment=timezone.parse(self.target_time)),
+ trigger=self.trigger,
Review Comment:
Why is this change needed? I don’t see `self.trigger` used anywhere else.
##########
airflow/sensors/date_time.py:
##########
@@ -85,9 +85,13 @@ class DateTimeSensorAsync(DateTimeSensor):
:param target_time: datetime after which the job succeeds. (templated)
"""
+ def __init__(self, **kwargs) -> None:
+ super().__init__(**kwargs)
+ self.trigger = DateTimeTrigger(moment=timezone.parse(self.target_time))
+
def execute(self, context: Context):
self.defer(
- trigger=DateTimeTrigger(moment=timezone.parse(self.target_time)),
+ trigger=self.trigger,
Review Comment:
Why is this change needed? I don’t see `self.trigger` used anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
