potiuk commented on PR #33685:
URL: https://github.com/apache/airflow/pull/33685#issuecomment-1691663498

   > My local shows the precommit for mypy for providers passed...
   > 
   > <img alt="image" width="630" 
src="https://user-images.githubusercontent.com/25823361/262976772-60742b20-176b-4a44-867f-d89cee27b35a.png";>
   > 🤔
   
   Happens Mypy uses heuristics that "guesses" type of the variables. And 
sometimes it gets it wrong when it does not run on "all files". Local version 
of pre-commit runs only on the files that are affected by commit and MyPy often 
will pull the other files and import them to feed it's heuristcs. But not 
always. So sometimes mypy is not able to guess correctly the type if it is not 
given explicitly all files. 
   
   Also sometimes the result depend if you use the same breeze image or whether 
you have an old one - because you might have an older version of providers.
   
   Also sometimes it depends on the cache you have locally built. Sometimes 
that cache is just not invalidated properly.
   
   And to add up, all this is succintly explained  **JUST** below the error you 
see in CI. Including precise instructions on what you should do to reproduce 
the failure you see locally.
   
   
![image](https://github.com/apache/airflow/assets/595491/679d135f-e323-4f98-b9b6-0d42f8f0fce0)
   
   
   I wonder (maybe you have an idea @RNHTTR ) how to better communicate it  
than the yellow message above :) ? Any ideas? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to