dstandish commented on code in PR #32990:
URL: https://github.com/apache/airflow/pull/32990#discussion_r1304469073
##########
airflow/models/baseoperator.py:
##########
@@ -1575,6 +1577,27 @@ def inherits_from_empty_operator(self):
# of its subclasses (which don't inherit from anything but
BaseOperator).
return getattr(self, "_is_empty", False)
+ def _trigger_timeout(
+ self, context: Context, timeout: timedelta | None = None
+ ) -> tuple[datetime | None, str | None]:
+ """Returns the earliest time to fail the task and the reason for it."""
Review Comment:
it's good to document the params. not necessarily obvious what "timeout"
means given that, apparently, it can mean different things
##########
airflow/models/baseoperator.py:
##########
@@ -1575,6 +1577,27 @@ def inherits_from_empty_operator(self):
# of its subclasses (which don't inherit from anything but
BaseOperator).
return getattr(self, "_is_empty", False)
+ def _trigger_timeout(
+ self, context: Context, timeout: timedelta | None = None
+ ) -> tuple[datetime | None, str | None]:
+ """Returns the earliest time to fail the task and the reason for it."""
Review Comment:
it's good to document the params. not necessarily obvious what the param
"timeout" means given that, apparently, it can mean different things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
