eladkal commented on code in PR #33405: URL: https://github.com/apache/airflow/pull/33405#discussion_r1304722753
########## airflow/providers/amazon/aws/sensors/utils.py: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.exceptions import AirflowException, AirflowSkipException + + +def raise_failed_or_skiping_exception( + *, soft_fail: bool = False, failed_message: str, skipping_message: str = "" +) -> None: + """Raise AirflowSkipException if self.soft_fail is set to True. Otherwise raise AirflowException.""" + if soft_fail: + raise AirflowSkipException(skipping_message or failed_message) + raise AirflowException(failed_message) Review Comment: so basically what you are after is to backport a fix we have in 2.7.1 The proper way to do it is: 1. Try to import the function from base_sensor if failed on import error then use the local version. 2. The local version should be private `_raise_failed_or_skiping_exception` so we can remove it without deprecation cycle. 3. There should be a note on the function to remove it when min airflow version for provider is >=2.7.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
