hussein-awala commented on code in PR #32990:
URL: https://github.com/apache/airflow/pull/32990#discussion_r1304780210
##########
airflow/exceptions.py:
##########
@@ -358,16 +362,15 @@ def __init__(
trigger,
method_name: str,
kwargs: dict[str, Any] | None = None,
- timeout: datetime.timedelta | None = None,
+ timeout: datetime.datetime | None = None,
+ timeout_reason: str | None = None,
):
super().__init__()
self.trigger = trigger
self.method_name = method_name
self.kwargs = kwargs
self.timeout = timeout
- # Check timeout type at runtime
- if self.timeout is not None and not hasattr(self.timeout,
"total_seconds"):
- raise ValueError("Timeout value must be a timedelta")
Review Comment:
I totally agree, I'll update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
