pierrejeambrun commented on code in PR #33611:
URL: https://github.com/apache/airflow/pull/33611#discussion_r1305444158
##########
airflow/www/static/js/cluster-activity/live-metrics/Health.tsx:
##########
@@ -107,11 +106,16 @@ const Health = (props: CenterProps) => {
latestHeartbeat={data?.triggerer?.latestTriggererHeartbeat}
mb={3}
/>
- <HealthSection
- title="Dag Processor"
- status={data?.dagProcessor?.status}
- latestHeartbeat={data?.dagProcessor?.latestDagProcessorHeartbeat}
- />
+ {!!standaloneDagProcessor && (
Review Comment:
All items should have a margin bottom except the last one to keep spacing
consistent. (padding of the card is already handled)
Both when the last item is the `Dag Processor` or the `Triggerer`.
To not add a ternary operator into the triggerer `mb` props you can simply
define a margin top on the `Dag Processor` section and remove the `mb` of the
Triggerer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
