dstandish commented on code in PR #33718:
URL: https://github.com/apache/airflow/pull/33718#discussion_r1306160894
##########
airflow/sensors/time_delta.py:
##########
@@ -64,7 +64,11 @@ class TimeDeltaSensorAsync(TimeDeltaSensor):
def execute(self, context: Context):
target_dttm = context["data_interval_end"]
target_dttm += self.delta
- self.defer(trigger=DateTimeTrigger(moment=target_dttm),
method_name="execute_complete")
+ self.defer(
+ trigger=DateTimeTrigger(moment=target_dttm),
+ method_name="execute_complete",
+ timeout=self.timeout,
Review Comment:
> it makes me a bit uncomfortable to remove the feature to be able to set a
specific deferral timeout on a given deferral. not that it's necessarily all
that useful, but it's there.
That comment I think was in reference to an earlier version of your PR, when
it was deprecating the deferral timeout altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
