potiuk commented on code in PR #33760:
URL: https://github.com/apache/airflow/pull/33760#discussion_r1306359609
##########
airflow/www/fab_security/manager.py:
##########
@@ -390,7 +390,7 @@ def my_oauth_user_info(sm, provider, response=None):
def wraps(provider, response=None):
ret = f(self, provider, response=response)
# Checks if decorator is well behaved and returns a dict as
supposed.
- if not type(ret) == dict:
+ if not isinstance(ret, dict):
Review Comment:
It's slightly different meaning, but yes - that's how it should be, so this
is really a bugfix (for example the first check would not work if we returned
OrderedDict, but the fix would)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
