dstandish commented on code in PR #33570:
URL: https://github.com/apache/airflow/pull/33570#discussion_r1306476108
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -51,6 +52,7 @@ class _UpstreamTIStates(NamedTuple):
done: int
success_setup: int
skipped_setup: int
+ failed_setup: int
Review Comment:
until now, everything in this class is *direct* upstreams. is failed_setup
direct only or does it include indirect too? if it includes indirect too, it
should probably be clarified through a more precise variable name. but perhaps
better would be to avoid mixing direct and indirect in the same class if it can
be avoided. perhaps we can just add the information through an optional
argument in `calculate` or something. this would also make the diff easier to
deal with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
