shahar1 opened a new pull request, #33786:
URL: https://github.com/apache/airflow/pull/33786
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
closes: #29069
### Concept
We want to add a pre-commit that checks for templated field logic checks
within the constructor of providers' operators to avoid issues like #27328.
Currently, I defined "invalid logic" as follows (I would be happy for
fine-tuning):
- If statements that their content does not include calls to `warnings.warn`
[1] nor `raise` statements [2].
- Return statements - I saw one randomly in one of the providers and removed
it.
- Loop statements - I didn't notice existing ones, but just in case someone
goes wild :)
### Notes
[1] Excluded due to deprecation warnings, which often appear in the
constructors.
[2] I assume that we would like to avoid exceptions as well, at least those
that are related to input validation - but we need to consider what to do in
case of exceptions that are related to deprecated params.
### Implementation
As of the time I sent this PR, it includes two commits:
- One that includes the pre-commit Python script and its YAML definition in
`pre-commit-config.yaml` - I excluded files that should be fixed in later PR;
see next.
- Another that includes modifications to specific operators, either to align
with the requirements immediately or by inserting a `FIXME` comment to do it
later (in case the complexity seems too high to address at the moment). If the
reviewers deem it necessary, I can create a separate pull request for this.
Regardless, I'll create a new issue for the necessary fixes.
### TODOs
- [ ] Open an issue for fixing untreated constructors.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
