This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new badcf24e17 Fix an edge case after refactoring back-reference breeze
command (#33790)
badcf24e17 is described below
commit badcf24e177b52ac87dd87c7e4ebad2727b2a4e7
Author: Jarek Potiuk <[email protected]>
AuthorDate: Sun Aug 27 06:32:51 2023 +0200
Fix an edge case after refactoring back-reference breeze command (#33790)
The #33626 change missed an edge case where back reference new
link was in the top-level folder and crashed with ValueError.
Unfortunately back-reference command is one that we do not run (yet)
in CI to verify if it works, because we need a checked-out airflow-site
for it, so such errors might go unnoticed. However this error is an
indication that we likely should add it to CI - in order to avoid
situation when the command is expected to be working at release
time.
---
dev/breeze/src/airflow_breeze/utils/add_back_references.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/dev/breeze/src/airflow_breeze/utils/add_back_references.py
b/dev/breeze/src/airflow_breeze/utils/add_back_references.py
index 4407a425c9..3feac9c017 100644
--- a/dev/breeze/src/airflow_breeze/utils/add_back_references.py
+++ b/dev/breeze/src/airflow_breeze/utils/add_back_references.py
@@ -111,9 +111,12 @@ def generate_back_references(link: str, base_path: Path):
for old, new in old_to_new:
# only if old file exists, add the back reference
if (versioned_provider_path / old).exists():
- split_new_path, file_name = new.rsplit("/", 1)
- dest_dir = versioned_provider_path / split_new_path
-
+ if "/" in new:
+ split_new_path, file_name = new.rsplit("/", 1)
+ dest_dir = versioned_provider_path / split_new_path
+ else:
+ file_name = new
+ dest_dir = versioned_provider_path
# finds relative path of old file with respect to new and
handles case of different file
# names also
relative_path = os.path.relpath(old, new)
