Bisk1 commented on code in PR #33746:
URL: https://github.com/apache/airflow/pull/33746#discussion_r1307086316
##########
airflow/utils/state.py:
##########
@@ -195,12 +190,7 @@ def color_fg(cls, state):
A list of states indicating that a task or dag is a success state.
"""
- terminating_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
- """
- A list of states indicating that a task has been terminated.
- """
-
- adoptable_states = frozenset(
+ adoptable_states: frozenset[TaskInstanceState] = frozenset(
Review Comment:
it's unrelated to this change - I noticed forgotten state annotation next to
the lines changed by myself so I fixed it to make it consistent with the rest
of the file - do you want me to revert it to keep PR focused purely on shutdown
state?
##########
airflow/utils/state.py:
##########
@@ -195,12 +190,7 @@ def color_fg(cls, state):
A list of states indicating that a task or dag is a success state.
"""
- terminating_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
- """
- A list of states indicating that a task has been terminated.
- """
-
- adoptable_states = frozenset(
+ adoptable_states: frozenset[TaskInstanceState] = frozenset(
Review Comment:
it's unrelated to shutdown state - I noticed forgotten state annotation next
to the lines changed by myself so I fixed it to make it consistent with the
rest of the file - do you want me to revert it to keep PR focused purely on
shutdown state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
