uranusjr commented on code in PR #33780: URL: https://github.com/apache/airflow/pull/33780#discussion_r1307170529
########## tests/providers/amazon/aws/hooks/test_glue.py: ########## @@ -30,6 +30,9 @@ from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook from airflow.providers.amazon.aws.hooks.glue import GlueJobHook +if TYPE_CHECKING: + from unittest.mock import MagicMock Review Comment: This is honestly somewhat awkward, we could just write `mock.MagicMock` without any additional imports… ########## tests/providers/amazon/aws/hooks/test_glue.py: ########## @@ -30,6 +30,9 @@ from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook from airflow.providers.amazon.aws.hooks.glue import GlueJobHook +if TYPE_CHECKING: + from unittest.mock import MagicMock Review Comment: This is honestly somewhat awkward, we could just write `mock.MagicMock` without any additional imports… -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
