Taragolis commented on PR #33602: URL: https://github.com/apache/airflow/pull/33602#issuecomment-1696031596
> THAT one looks pretty complete not POC :D Well for me this implementation is still between some dirty hack and something missing in Connection+Hook integration. This PR sits for a long time in my local brach because I can't find a better way to implements such integration, other ideas was (Option 1) Just create inheritance of existed DockerHook, DockerOperator, docker decorator, DockerSwarmOperator --- Required support all of them independently, update decorator and need to track is change in parent classes break child classes. (Option 2) Create something like `DbApiHook` but for docker --- I've also thinking about it, bet the problem that DockerHook and operators, only use connection for login to Docker Registry, and have pretty stable specification for what it required (Option 3) Change in Airflow Connection + Airflow Hooks at all --- Too many efforts required, and most of them break something in Airflow 2.x, so it should come thought discussion first --- So this implementation basically is a middle of Option 2 and Option 3, I hope that at least it better than [Airflow ECR Plugin](https://github.com/asandeep/airflow-ecr-plugin) from Airflow Ecosystem Page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
