potiuk commented on code in PR #28900:
URL: https://github.com/apache/airflow/pull/28900#discussion_r1308388311
##########
airflow/models/taskinstance.py:
##########
@@ -186,23 +188,23 @@ def set_current_context(context: Context) ->
Generator[Context, None, None]:
)
-def _stop_remaining_tasks(*, self, session: Session):
+def _stop_remaining_tasks(*, task_instance, session: Session):
Review Comment:
I think it's good to distinquish where we use "DB" one and where we use the
Pydantic one.
##########
airflow/models/taskinstance.py:
##########
@@ -186,23 +188,23 @@ def set_current_context(context: Context) ->
Generator[Context, None, None]:
)
-def _stop_remaining_tasks(*, self, session: Session):
+def _stop_remaining_tasks(*, task_instance, session: Session):
Review Comment:
I think it's good to distinquish where we use "DB" one and where we can have
also the Pydantic one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
