Taragolis commented on code in PR #33881:
URL: https://github.com/apache/airflow/pull/33881#discussion_r1308741602


##########
airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -24,7 +24,6 @@
 
 if TYPE_CHECKING:
     from mypy_boto3_appflow.client import AppflowClient
-    from mypy_boto3_appflow.type_defs import TaskOutputTypeDef, TaskTypeDef
 

Review Comment:
   Just FYI for someone who want to keep type-checking for boto3/botocore 
expected values.
   For correct work we should have exactly same version of 
`mypy-boto3-{service-name}` and boto3
   
   ```console
   root@5e78bbc9c51e:/opt/airflow# pip list | grep boto
   aiobotocore                              2.6.0
   boto                                     2.49.0
   boto3                                    1.28.17
   botocore                                 1.31.17
   mypy-boto3-appflow                       1.28.16
   mypy-boto3-rds                           1.28.34
   mypy-boto3-redshift-data                 1.28.16
   mypy-boto3-s3                            1.28.27
   types-boto                               2.49.18.9
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to