Taragolis commented on code in PR #33941:
URL: https://github.com/apache/airflow/pull/33941#discussion_r1310956198
##########
tests/providers/amazon/aws/waiters/test_custom_waiters.py:
##########
@@ -71,7 +71,7 @@ def test_init(self):
waiter = BaseBotoWaiter(client_name, waiter_model_config)
# WaiterModel objects don't implement an eq() so equivalence checking
manually.
- for attr, _ in expected_model.__dict__.items():
+ for attr in expected_model.__dict__.keys():
Review Comment:
```suggestion
for attr in expected_model.__dict__:
```
##########
tests/providers/amazon/aws/waiters/test_custom_waiters.py:
##########
@@ -116,7 +116,7 @@ def test_existing_waiter_inherited(self):
assert_all_match(hook_waiter.name, client_waiter.name,
boto_waiter.name)
assert_all_match(len(hook_waiter.__dict__),
len(client_waiter.__dict__), len(boto_waiter.__dict__))
- for attr, _ in hook_waiter.__dict__.items():
+ for attr in hook_waiter.__dict__.keys():
Review Comment:
```suggestion
for attr in hook_waiter.__dict__:
```
##########
tests/www/views/test_views_acl.py:
##########
@@ -122,7 +122,7 @@ def acl_app(app):
yield app
- for username, _ in USER_DATA.items():
+ for username in USER_DATA.keys():
Review Comment:
```suggestion
for username in USER_DATA:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
