ephraimbuddy commented on code in PR #33932:
URL: https://github.com/apache/airflow/pull/33932#discussion_r1311701311
##########
airflow/www/views.py:
##########
@@ -5146,8 +5147,13 @@ def varimport(self):
flash("Missing file or syntax error.", "error")
return redirect(self.get_redirect())
else:
+ skipped = set()
suc_count = fail_count = 0
for k, v in variable_dict.items():
+ if
session.scalar(select(models.Variable).where(models.Variable.key == k)):
Review Comment:
Seems like this will be better since we are not querying a lot of values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
