potiuk commented on PR #33637:
URL: https://github.com/apache/airflow/pull/33637#issuecomment-1701851268

   > > BTW. I REALLY wanted to add such comment in the .json files - but 
unfortunately, json specification does not allow comments (hence the README.md).
   > 
   > @potiuk maybe it is it possible to switch these files to .jsonc, "JSON 
with Comments"? VSCode supports it for example 
(https://code.visualstudio.com/docs/languages/json#_json-with-comments), I am 
not sure if it is possible to easily include support in this project.
   
   Well. We need  to read them in setup.py using nothing by stdlib of python in 
all versions we support. Otherwise I'd just use YAML. The file is read by 
`python setup.py` that should work without being in any specifc venv, no 
libraries installed, no IDEs or anything. Nothing beats simplicity of `import 
json; provider_dependencies_dict =json.loads( Path(__name__.parent) / 
"generated" /"provider_dependencies.json").text)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to