uranusjr commented on code in PR #33975:
URL: https://github.com/apache/airflow/pull/33975#discussion_r1312519951
##########
airflow/executors/local_executor.py:
##########
@@ -331,15 +331,15 @@ def execute_async(
def sync(self):
"""Sync will get called periodically by the heartbeat method."""
- while True:
- try:
+ try:
+ while True:
results = self.executor.result_queue.get_nowait()
try:
self.executor.change_state(*results)
finally:
self.executor.result_queue.task_done()
- except Empty:
- break
+ except Empty:
+ pass
Review Comment:
In the same sense as e.g. #33981, should this be replaced with `suppress`
too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
