Taragolis commented on code in PR #33960:
URL: https://github.com/apache/airflow/pull/33960#discussion_r1312748153


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -710,3 +710,16 @@ additional-extras:
   - name: cncf.kubernetes
     dependencies:
       - apache-airflow-providers-cncf-kubernetes>=7.2.0
+
+config:
+  aws:
+    description: This section applies settings for Amazon Web Services (AWS) 
integration.
+    options:
+      session_factory:
+        description: |
+          Full import path to the class which implements custom session 
factory for ``boto3.session.Session``,
+          for more detail please have a look at 
:ref:`howto/connection:aws:session-factory`.
+        default: ~
+        example: my_company.aws.MyCustomSessionFactory
+        type: string
+        version_added: ~

Review Comment:
   I guess it is additional validation just in case for Airflow Core
   E.g.: option would added to 2.8, but in 2.7.x it do not make any affect on 
configuration side .
   
   
https://github.com/apache/airflow/blob/b82ce61285f3f4f0c7eccb2c3effaef53c9fb84e/airflow/configuration.py#L571-L576
   
   And this remove futures configs, during generation documentatio 
   
https://github.com/apache/airflow/blob/2663b177a666ee150f86bd16ad51526319fa7adb/docs/conf.py#L434-L442
   
   In general this logic designed in the time, when providers doesn't have 
their own documentation for configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to