barrysteyn commented on PR #28829:
URL: https://github.com/apache/airflow/pull/28829#issuecomment-1704668176
This change has totally broken things... for example, I have class that
needs to be on the `allowed_deserialization_classes` list... the error message
I get is `libs.dynamodb.models.ideas.IdeasModel` is not on the allowed list.. I
do understand that this is regex that is being matched against, however
altering the regex is not (in my opinion) good. Firstly, people who are doing
this are technical and should know that a `.` matches anything.
But... the worst thing is that things don't work... For example, I have
tested things by putting the following in the`allowed_deserialization_classes`
(remember I am testing *libs.dynamodb.models.ideas.IdeasModel* for a match):
1. `libs.dynamodb.models.ideas.IdeasModel` --> False (not expected)
2. `libs[.]dynamodb[.]models[.]ideas[.]IdeasModel` --> True (weird)
3. `libs.dynamodb.*` --> False
4. `libs.*` --> True (this mimic'd the unit test of this change).
It is obvious that the replace `.` with `..` is the culprit. Instead, I
suggest we undo the changes, and rather document in detail on how to use the
regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
