uranusjr commented on code in PR #34060: URL: https://github.com/apache/airflow/pull/34060#discussion_r1314647254
########## scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py: ########## @@ -24,18 +24,18 @@ import os import re import sys -from os.path import dirname +from pathlib import Path from rich import print from rich.console import Console from rich.table import Table -AIRFLOW_SOURCES_DIR = os.path.join(dirname(__file__), os.pardir, os.pardir, os.pardir) +AIRFLOW_SOURCES_DIR = Path(__file__).resolve().parents[3] Review Comment: That’d be awesome, although we can focus on the lines changed in this PR first. ########## scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py: ########## @@ -24,18 +24,18 @@ import os import re import sys -from os.path import dirname +from pathlib import Path from rich import print from rich.console import Console from rich.table import Table -AIRFLOW_SOURCES_DIR = os.path.join(dirname(__file__), os.pardir, os.pardir, os.pardir) +AIRFLOW_SOURCES_DIR = Path(__file__).resolve().parents[3] Review Comment: That’d be awesome, although we can focus on the lines changed in this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
