potiuk commented on code in PR #34004:
URL: https://github.com/apache/airflow/pull/34004#discussion_r1315197970


##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -366,6 +374,14 @@ breeze build-docs --clean-build \
   ...
 ```
 
+You can also use shorthand names as arguments instead of using the full names
+for airflow providers. Example:
+
+```shell script
+cd "${AIRFLOW_REPO_ROOT}"
+breeze build-docs package1 package2 --clean-build

Review Comment:
   > there is no issue... the script handled both doc build and add back 
referenced but when I didn't use the script I simply ran both commands. I 
actually prefer it that way. it gives better control over the process.
   
   (just to clarify - this is a different script :) ... it was about 
publishing, not building :)
   
   > What I meant is that now we don't need the build_provider_documentation.sh 
any more so it can be removed.
   
   Correct. But I want to really do that in the follow-up when we also switch  
the CI to use the new arguments rather than `--package-filter`, to separte 
"breeze" changes with "using breeze" changes.



##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -366,6 +374,14 @@ breeze build-docs --clean-build \
   ...
 ```
 
+You can also use shorthand names as arguments instead of using the full names
+for airflow providers. Example:
+
+```shell script
+cd "${AIRFLOW_REPO_ROOT}"
+breeze build-docs package1 package2 --clean-build

Review Comment:
   > there is no issue... the script handled both doc build and add back 
referenced but when I didn't use the script I simply ran both commands. I 
actually prefer it that way. it gives better control over the process.
   
   (just to clarify - this is a different script :) ... it was about 
publishing, not building :)
   
   > What I meant is that now we don't need the build_provider_documentation.sh 
any more so it can be removed.
   
   Correct. But I want to really do that in the follow-up when we also switch  
the CI to use the new arguments rather than `--package-filter`, to separate 
"breeze" changes with "using breeze" changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to