uranusjr commented on code in PR #34027:
URL: https://github.com/apache/airflow/pull/34027#discussion_r1315590389
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1192,7 +1192,7 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
)
active_runs_of_dags[dag.dag_id] += 1
if self._should_update_dag_next_dagruns(
- dag, dag_model, active_runs_of_dags[dag.dag_id],
session=session
+ dag, dag_model, None, active_runs_of_dags[dag.dag_id],
session=session
Review Comment:
```suggestion
dag,
dag_model,
last_dag_run=None,
total_active_runs=active_runs_of_dags[dag.dag_id],
session=session,
```
this would improve readability dignificantly. It may also be a good idea to
make those arguments keyword-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
