uranusjr commented on code in PR #33901:
URL: https://github.com/apache/airflow/pull/33901#discussion_r1316512464
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -36,8 +38,9 @@ class BaseAuthManager(LoggingMixin):
Auth managers are responsible for any user management related operation
such as login, logout, authz, ...
"""
- def __init__(self):
+ def __init__(self, app: Flask):
Review Comment:
Mypy would require an annotation in strict mode, i.o.w. it doesn’t think
this is that special, compared to e.g. `self`. But what is special is of course
subjective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
