uranusjr commented on code in PR #34121:
URL: https://github.com/apache/airflow/pull/34121#discussion_r1316774161
##########
airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py:
##########
@@ -149,7 +149,7 @@ def execute(self, context: Context):
)
raise AirflowException(message)
total_row_count =
self._decide_and_flush(converted_rows_with_action=converted_rows_with_action)
- self.log.info("Facebook Returned %s data points in total: ",
total_row_count)
+ self.log.info("Facebook Returned %s data points in total:",
total_row_count)
Review Comment:
```suggestion
self.log.info("Facebook Returned %s data points in total.",
total_row_count)
```
I don’t even understand why the colon is there…
##########
airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py:
##########
@@ -149,7 +149,7 @@ def execute(self, context: Context):
)
raise AirflowException(message)
total_row_count =
self._decide_and_flush(converted_rows_with_action=converted_rows_with_action)
- self.log.info("Facebook Returned %s data points in total: ",
total_row_count)
+ self.log.info("Facebook Returned %s data points in total:",
total_row_count)
Review Comment:
```suggestion
self.log.info("Facebook Returned %s data points in total.",
total_row_count)
```
I don’t even understand why the colon is there…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
