potiuk commented on PR #34108: URL: https://github.com/apache/airflow/pull/34108#issuecomment-1709806138
I think those kind of rules are rarely read and we have two approaches there that 'work' a) hope that people will follow what is in the code (not perfect but mostly works) - this is a stage we are currently in b) better - add pre-commit to do ast parsing and add rules of things we want do not want to have. I'd say it would be great if thos unification that can be done (imports are generally easy) are added as a rule to pre-commits Maybe you can work with @eumiro together to determine the list of rules that can be automatically verified and and write a pre&commit doing it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
