ephraimbuddy commented on issue #34023:
URL: https://github.com/apache/airflow/issues/34023#issuecomment-1710005257

   > Ok. Found a fix for this but still need to reason more about it:
   > 
   > ```diff
   > diff --git a/airflow/models/taskinstance.py 
b/airflow/models/taskinstance.py
   > index 82282eb39d..31fc1bfa9b 100644
   > --- a/airflow/models/taskinstance.py
   > +++ b/airflow/models/taskinstance.py
   > @@ -2859,7 +2859,7 @@ class TaskInstance(Base, LoggingMixin):
   >          # and "ti_count == ancestor_ti_count" does not work, since the 
further
   >          # expansion may be of length 1.
   >          if not _is_further_mapped_inside(upstream, common_ancestor):
   > -            return ancestor_map_index
   > +            return abs(ancestor_map_index)
   >  
   >          # Otherwise we need a partial aggregation for values from 
selected task
   >          # instances in the ancestor's expansion context.
   > ```
   
   Hi @uranusjr , can you chime in on this? 
   I can't find a way to test this but this actually solved this case for 
mapped taskgroup with one failed. 
   when we calculate ancestor_map_index, we multiply with self.map_index which 
can be -1. Are there reasons why we chose to not care if the map_index is 
negative or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to