jens-scheffler-bosch commented on code in PR #34234:
URL: https://github.com/apache/airflow/pull/34234#discussion_r1320725719
##########
airflow/models/dag.py:
##########
@@ -447,6 +453,7 @@ def __init__(
owner_links: dict[str, str] | None = None,
auto_register: bool = True,
fail_stop: bool = False,
+ default_run_id: Callable | None = None,
Review Comment:
Can you add some type hints so that mypy can check the signature if the
callable is customized?
```suggestion
default_run_id: Callable[[DagRunType, DateTime, DataInterval, dict],
str] | None = None,
```
##########
airflow/models/dag.py:
##########
@@ -3745,6 +3758,7 @@ def dag(
owner_links: dict[str, str] | None = None,
auto_register: bool = True,
fail_stop: bool = False,
+ default_run_id: Callable | None = None,
Review Comment:
+1 here - Can you add some type hints so that mypy can check the signature
if the callable is customized?
```suggestion
default_run_id: Callable[[DagRunType, DateTime, DataInterval, dict],
str] | None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
