uranusjr commented on code in PR #34263:
URL: https://github.com/apache/airflow/pull/34263#discussion_r1320996236
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -331,10 +331,10 @@ class S3CreateObjectOperator(BaseOperator):
:ref:`howto/operator:S3CreateObjectOperator`
:param s3_bucket: Name of the S3 bucket where to save the object.
(templated)
- It should be omitted when `bucket_key` is provided as a full s3:// url.
+ It should be omitted when `s3_key` is provided as a full s3:// url.
Review Comment:
```suggestion
It should be omitted when ``s3_key`` is provided as a full s3:// url.
```
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -331,10 +331,10 @@ class S3CreateObjectOperator(BaseOperator):
:ref:`howto/operator:S3CreateObjectOperator`
:param s3_bucket: Name of the S3 bucket where to save the object.
(templated)
- It should be omitted when `bucket_key` is provided as a full s3:// url.
+ It should be omitted when `s3_key` is provided as a full s3:// url.
:param s3_key: The key of the object to be created. (templated)
It can be either full s3:// style url or relative path from root level.
- When it's specified as a full s3:// url, please omit bucket_name.
+ When it's specified as a full s3:// url, please omit `s3_bucket`.
Review Comment:
```suggestion
When it's specified as a full s3:// url, please omit ``s3_bucket``.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
