uranusjr commented on code in PR #34222:
URL: https://github.com/apache/airflow/pull/34222#discussion_r1321264761
##########
airflow/providers/amazon/aws/triggers/rds.py:
##########
@@ -99,13 +99,14 @@ async def run(self):
yield TriggerEvent({"status": "success", "response": self.response})
-_waiter_arg = {
- RdsDbType.INSTANCE: "DBInstanceIdentifier",
- RdsDbType.CLUSTER: "DBClusterIdentifier",
+# using Any for the keys to "disable" type checks because Union types.
Review Comment:
Why does this need to disable type checking? Aren’t those keys just strings?
https://github.com/apache/airflow/blob/f70c10748b23d6f06eeb520b8854a87345cb9765/airflow/providers/amazon/aws/utils/rds.py#L22-L26
##########
airflow/providers/amazon/aws/triggers/rds.py:
##########
@@ -99,13 +99,14 @@ async def run(self):
yield TriggerEvent({"status": "success", "response": self.response})
-_waiter_arg = {
- RdsDbType.INSTANCE: "DBInstanceIdentifier",
- RdsDbType.CLUSTER: "DBClusterIdentifier",
+# using Any for the keys to "disable" type checks because Union types.
Review Comment:
Why does this need to disable type checking? Aren’t those keys just strings?
https://github.com/apache/airflow/blob/f70c10748b23d6f06eeb520b8854a87345cb9765/airflow/providers/amazon/aws/utils/rds.py#L22-L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
